Skip to content

Add features: Silent Pod and Pod Diagnostics#32

Merged
marionbarker merged 28 commits into
LoopKit:mainfrom
loopandlearn:silent_pod_and_diagnostics
Apr 13, 2024
Merged

Add features: Silent Pod and Pod Diagnostics#32
marionbarker merged 28 commits into
LoopKit:mainfrom
loopandlearn:silent_pod_and_diagnostics

Conversation

@marionbarker
Copy link
Copy Markdown
Collaborator

@marionbarker marionbarker commented Apr 2, 2024 •
edited
Loading

This PR adds the Silent Pod and Pod Diagnostics features to the OmniKit screen for Eros pods:

The Silent Pod and Pod Diagnostics rows are added as shown in the graphic below.

User-facing changes:

  • Pod notifications include an option to silence the pod
    • When silenced, alerts are only on the phone, the pod does not beep
    • Pod faults, end of life and out of insulin still alarm on the pod regardless of this setting
  • The previous pod row is moved under the pod details row to make it easier to find
  • A pod diagnostics row is added to the end of the pod screen
    • various diagnostics rows are added in a new sub-screen
    • Eros pod users can check their pod RSSI to assist in debugging pump communication issues

The before (left) and after (right) screenshots of the Omnipod screen is shown below.

omnikit-pr-32

@marionbarker
Merge pull request #1 from itsmojo/pod-setup-resume-retry-prevention
60ae9b6 
Eliminate user retries on pod setup resumes (Loop issue #2117 follow up)
@marionbarker
Merge pull request #2 from itsmojo/allow-timezone-sync-without-pod
7a149f7 
Allow timezone sync without an active pod
@marionbarker
Merge pull request #3 from itsmojo/deactivate-pod-fault-info
048c209 
Deactivate pod fault info
@marionbarker
use setState instead of mutateState for OmniKit
0758511
@marionbarker
rename alert slots to descriptive titles for OmniKit
0207f27
@marionbarker
Add SilentPod, diagnotics and update Pod menu
7439fc8
@marionbarker
remove file that is not used
50bc368
@marionbarker
fix typo in comment
1568d54
@marionbarker
revert inadvertent change to packet parser
20fd39d
@marionbarker
put Silence Pod and Pod Diagnostics behind build-time flag
a9435f4 
* supports Loop by using DEBUG_FEATURES_ENABLED flag
* make suspend message more generic
@marionbarker
Merge pull request #4 from loopandlearn/diy_flag_for_silence_diagnostics
0174b22 
put Silence Pod and Pod Diagnostics behind build-time flag
@marionbarker
enable user to set another expiration reminder for current pod
d2a84c5
@marionbarker
update message about pod reminder
ef8d6ce
@marionbarker
Merge branch 'main' into silent_pod_and_diagnostics
c3df57d
@marionbarker marionbarker requested review from itsmojo and ps2 April 2, 2024 17:09
itsmojo
itsmojo reviewed Apr 3, 2024
View reviewed changes
Comment thread OmniKitUI/Views/OmnipodSettingsView.swift Outdated
itsmojo
itsmojo reviewed Apr 3, 2024
View reviewed changes
Comment thread OmniKitUI/Views/OmnipodSettingsView.swift Outdated
itsmojo
itsmojo reviewed Apr 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@itsmojo itsmojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for extra spaces in allowDebugFeatures if statements and a big concern about using allowDebugFeatures to conditionally enable displaying the Silence Pod option which I believe should always be available. If this option really must be conditional like this, additional thought and code will be needed to properly handle certain possible cases.

@marionbarker
Copy link
Copy Markdown
Collaborator Author

marionbarker commented Apr 3, 2024 •
edited
Loading

The DIY pump managers will not be used by Tidepool, so I reverted the commit that added the allowDebugFeatures check.

@marionbarker
Copy link
Copy Markdown
Collaborator Author

marionbarker commented Apr 3, 2024

Graphics for the modified rows and new features are reporting in the OmniBLE PR.

For modified rows:

For new feature: Silent Pod:

For new feature: Pod Diagnostics:

ps2
ps2 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ps2 ps2 self-requested a review April 8, 2024 03:46
ps2
ps2 requested changes Apr 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asyncAction and FirstAppear are wrongly pushing view model logic into the view.

@marionbarker
Copy link
Copy Markdown
Collaborator Author

marionbarker commented Apr 10, 2024

This PR has been updated as requested and is ready for final review.

@marionbarker marionbarker merged commit 30428b7 into LoopKit:main Apr 13, 2024
@bjornoleh bjornoleh mentioned this pull request Apr 14, 2024
Merged
@marionbarker marionbarker deleted the silent_pod_and_diagnostics branch June 29, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ps2 ps2 ps2 requested changes

+1 more reviewer

@itsmojo itsmojo itsmojo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marionbarker @ps2 @itsmojo